Merge pull request #146 from RSGInc/fix_zero_trips

Count zero trip days for unweighted data
RSGInc · Mar 8, 2024 · 893da25 · 893da25
2 parents 0ff8fa1 + ca746ad
commit 893da25
Show file tree

Hide file tree

Showing 48 changed files with 123 additions and 120 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,6 +1,6 @@
 Package: travelSurveyTools
 Title: travelSurveyTools
-Version: 2.3.6
+Version: 2.3.7
 Authors@R: c(
     person("RSG", "Inc.", , "[email protected]", role = c("aut", "cre")),
     person("Ashley", "Asmus", , "[email protected]", role = "aut"),

diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,9 @@
 # travelSurveyTools 2.3.6
 
+- Fixing `hts_prep_triprate` to properly calculate days with zero trips.
+
+# travelSurveyTools 2.3.6
+
 - Fixing bug in `hts_prep_triprate` for variables that appear in trip and day tables.
 
 # travelSurveyTools 2.3.5

diff --git a/R/hts_prep_triprate.R b/R/hts_prep_triprate.R
@@ -171,7 +171,7 @@ if (length(summarize_by) > 0) {
   }
 
   if (!weighted) {
-    triprate_dt = triprate_dt[, .(num_trips = .N),
+    triprate_dt = triprate_dt[, .(num_trips = sum(!is.na(get(trip_id)))),
                               by = triprate_cols_all
     ]
   }

diff --git a/docs/404.html b/docs/404.html
diff --git a/docs/CONTRIBUTING.html b/docs/CONTRIBUTING.html
diff --git a/docs/LICENSE.html b/docs/LICENSE.html
diff --git a/docs/PULL_REQUEST_TEMPLATE.html b/docs/PULL_REQUEST_TEMPLATE.html
diff --git a/docs/articles/a01_getting_started.html b/docs/articles/a01_getting_started.html