-
Notifications
You must be signed in to change notification settings - Fork 952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Resolved the issue of being unable to reset it to empty after using the proxy. #2788
Conversation
Thank you for your contribution. We will review it promptly. |
@IzumiMasaharu, please use Conventional Commits format for your PR title. Your PR title should follow this format: Common types include:
Examples:
For more details, please visit: https://www.conventionalcommits.org/ |
@IzumiMasaharu is attempting to deploy a commit to the RSS3 Team on Vercel. A member of the Team first needs to authorize it. |
Suggested PR Title:
Change Summary: Code Review: |
Linting and formatting issues were automatically fixed. Please review the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
Thank you @IzumiMasaharu for your contribution! 🎉 Your pull request has been merged and we really appreciate your help in making this project better. We hope to see more contributions from you in the future! 💪 |
Description
Resolved the issue of being unable to reset it to empty after using the proxy.
PR Type
Linked Issues
#2786
Additional context
I would like to explain my method to fix the bug below.
proxy
option in the~/Library/Application Support/Follow/db.json
file is updated in real time.proxy
indb.json
stops updating.db.json
.Therefore, it can be concluded that the function
setProxyConfig
handles both the empty string and invalid string inputs in the same way——not to update thedb.json
file.To differentiate between these two cases, I chose to modify the return value of the function
normalizeProxyUri
called within functionsetProxyConfig
. Specifically, when the input is an empty string, I made the functionnormalizeProxyUri
return an empty string. This allows the functionsetProxyConfig
to update theproxy
field indb.json
to an empty string viastore.set
.Note: Since I haven’t set up the related environment on my computer, I hope someone else can help with building it and testing whether my method can actually resolve Issue #2786 without causing any other issues.
Changelog