Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[src][thread]update change prio func #9358

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zmshahaha
Copy link
Contributor

@zmshahaha zmshahaha commented Aug 28, 2024

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

之前的优先级调整只调整current_priority,但mutex获取时会临时改变优先级,解锁后会恢复为init_prio,导致优先级更新失效

你的解决方案是什么 (what is your solution)

分离临时调整优先级以及永久调整优先级api,其中永久调整优先级的api在线程释放所有持有的mutex后才生效

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@zmshahaha zmshahaha marked this pull request as draft August 28, 2024 08:06
@github-actions github-actions bot added the Kernel PR has src relate code label Aug 28, 2024
src/scheduler_comm.c Outdated Show resolved Hide resolved
@zmshahaha zmshahaha marked this pull request as ready for review September 14, 2024 03:00
@polarvid polarvid closed this Sep 14, 2024
@polarvid polarvid reopened this Sep 14, 2024
@polarvid
Copy link
Contributor

重新触发静态检查。

@mysterywolf
Copy link
Member

Change current priority 这个API是否可以作为static私有函数?因为用户不会寄希望说改变current priority, 然后不确定什么时候 current priority又会被莫名其妙的还原。current priority 应该是内部信息,用户不需要感知。

@mysterywolf
Copy link
Member

直接重新规范rt_sched_thread_change_priority语义就可以了,rt_sched_thread_change_priority就是change init_priority,即标题说的永久优先级,用户也不需要管我当前是否有mutex,反正设置完成之后 优先级就会改变就是了。

@zmshahaha
Copy link
Contributor Author

Change current priority 这个API是否可以作为static私有函数?因为用户不会寄希望说改变current priority, 然后不确定什么时候 current priority又会被莫名其妙的还原。current priority 应该是内部信息,用户不需要感知。

主要是mutex用了这个函数,mutex和chang prio不在一个文件里面,所以没用static

@polarvid
Copy link
Contributor

polarvid commented Sep 14, 2024

直接重新规范rt_sched_thread_change_priority语义就可以了,rt_sched_thread_change_priority就是change init_priority,即标题说的永久优先级,用户也不需要管我当前是否有mutex,反正设置完成之后 优先级就会改变就是了。

rt_sched 系列 API 是被宏保护的,不在 src/特定 IPC 源代码里面是看不到头文件定义的。如果需要修改,主要考虑 rt_thread_control 的语义和对应 mutex 控制下的逻辑即可。

因此这个 PR 的意图也主要是纠正通过 rt_thread_control 修改线程优先级(rt_thread_control -> rt_sched_thread_change_priority)的实现。

@mysterywolf
Copy link
Member

@zmshahaha @polarvid OK 麻烦 把这两个注释写全,写清楚这两个函数的功能,以及强调一下一般用户不会用到change_current_priority这个函数,这个函数实际是一个内部函数,受限使用,除非其完全理解内核的意义。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kernel PR has src relate code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants