Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat]add pci api #9443

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[feat]add pci api #9443

wants to merge 1 commit into from

Conversation

zhuzhuzhus
Copy link
Contributor

@zhuzhuzhus zhuzhuzhus commented Sep 14, 2024 •
edited
Loading

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

add pci api,user maybe need addr of io or memory and remap it so can have a api to return struct which include the mem info that user need

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:

  • .config:

  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@zhuzhuzhus zhuzhuzhus closed this Sep 14, 2024
@zhuzhuzhus zhuzhuzhus reopened this Sep 14, 2024
@zhuzhuzhus zhuzhuzhus closed this Sep 14, 2024
@zhuzhuzhus zhuzhuzhus reopened this Sep 14, 2024
@zhuzhuzhus zhuzhuzhus changed the title [add]add pci api [fit]add pci api Sep 14, 2024
@zhuzhuzhus zhuzhuzhus changed the title [fit]add pci api [feat]add pci api Sep 14, 2024
polarvid
polarvid reviewed Sep 30, 2024
View reviewed changes
Copy link
Contributor

@polarvid polarvid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

麻烦作者主动 rebase 一下提交记录，在 commit message 补充有意义的说明和解释，方便其它开发者 Review 相关修改。谢谢。

@zhuzhuzhus
add pci api,the pci/pcie driver writer can use this to get resource o…
96ccb89 
…f current device with flag,there are three flag :

1. PCI_BUS_REGION_F_MEM it mean memory space
2. PCI_BUS_REGION_F_IO it mean io space
3. PCI_BUS_REGION_F_PREFETCH it mean prefetchable memory
@zhuzhuzhus
Copy link
Contributor Author

麻烦作者主动 rebase 一下提交记录，在 commit message 补充有意义的说明和解释，方便其它开发者 Review 相关修改。谢谢。

已rebase && 修改commit描述

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polarvid polarvid polarvid approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
component: drivers/pci component: drivers Component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhuzhuzhus @polarvid @Rbb666