ENH: set division threshold for SART #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonRit
requested changes
Apr 14, 2020
| * noisy and/or simulated data. | ||
| */ | ||
| void | ||
| SetDivisionThreshold(ProjectionPixelType threshold); |
There was a problem hiding this comment.
Please use ITK macros itkSetMacro itkGetMacro for set and get (which is missing).
| void | ||
| SARTConeBeamReconstructionFilter<TVolumeImage, TProjectionImage>::SetDivisionThreshold(ProjectionPixelType threshold) | ||
| { | ||
| m_DivideProjectionFilter->SetThreshold(threshold); |
There was a problem hiding this comment.
I understand now why you haven't used ITK macros. I used to do similar things and RTK is full of such strategies. I now think it's not good because if you change the threshold value, the filter is not modified and the filter won't update if you call Update() again. My suggestion: create a m_DivisionThreshold filter parameter, Set Get it with the ITK macros and pass it to the filter in the GenerateOutputInformation. That's the most readable solution I believe.
My attempt at fixing RTKConsortium#151
acoussat
force-pushed
the
threshold-sart
branch
from
1d2100e
to
a0e604c
Compare
|
Updated my commit. Hope everything is correct now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My attempt at fixing #151. From what I understood of the problem, this should suffice, but I might be missing something. I guess the modifications are automatically propagated to the Python wrappings.
One remark though: the current implementation allows setting a negative threshold. Is that a problem? ITK seems to allow this behavior.