-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cuda array interface #617
base: master
Are you sure you want to change the base?
Cuda array interface #617
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to be able to compile both the CudaCommon latest release and master's head versions, following RTK's policy for ITK versions. In this case, it might be doable by testing whether GetGPUBufferPointerPtr
is defined as is done in eb90fb4 for an ITK macro. Note the regular expression in the log. Do you want to give it a try or should I try to implement this?
Should we add a target_compile_definition in ITKCudaCommon to peform such a check (e.g. "CudaDataManagerHasGetGPUBufferPointerPtr")? Or do you prefer to use the CudaCommon_VERSION as suggested in RTKConsortium/ITKCudaCommon#42 ? Or something else ? |
No preference, the second one sounds simpler to me. But it is not defined for the latest release so it will just be #ifdef CUDA_COMMON_MAJOR_VERSION
#else
#endif I guess |
Requires CudaCommon@e2f19a1 to access the source dir
2706a29
to
415aa1b
Compare
@SimonRit To preserve backward compatibility with CudaCommon, it was also required to add checks in itkCudaImageRTK.wrap, as it uses CudaCommon_SOURCE_DIR which is undefined before CudaCommon 2.0. The linter is unhappy with the new #ifdef, let me know if you have any other feedback before I fix the style.Thanks |
Implement changes required on the RTK side following the implementation of cuda_array_interface in CudaCommon
Requires ITKCudaCommon#42