ENH: Account for lateral detector offsets in Zeng's forward projector #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, sorry I didn't take it into account in the first place. Should we do the same for the back projector ? |
SimonRit
force-pushed
the
ZengDetectorOffsets
branch
from
6027059
to
af10890
Compare
Good point, I have force-pushed a modification. Note that taking the backprojector is not exactly the adjoint of the forward, I believe we would need to splat the rotation instead of taking the inverse. But that can be done in another PR. |
arobert01
reviewed
Sep 17, 2024
| pointSlice.GetVectorFromOrigin() * m_VectorOrthogonalDetector; | ||
| } | ||
| if (this->GetInput(2)) | ||
| { | ||
| m_AttenuationMapTransform->SetRotation(0., angle, 0.); | ||
| m_Transform->SetTranslation(itk::MakeVector( |
There was a problem hiding this comment.
Should not it be m_AttenuationMapTransform instead of m_Transform ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.