Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the pending deprecation warning for achromatic gaussian beams #441

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

bhazelton
Copy link
Member

@bhazelton bhazelton commented Jan 18, 2024

Description

Remove the deprecation warning on using sigma to define gaussian beams. Analytic beams will move to pyuvdata soon and will retain this functionality, so no deprecation is needed.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Reference simulation update or replacement
  • Documentation change (documentation changes only)
  • Version change
  • Build or continuous integration change

Checklist:

For all pull requests:

Documentation change checklist:

  • Any updated docstrings use the numpy docstring format.
  • If this is a significant change to the readme or other docs, I have checked that they are rendered properly on ReadTheDocs. (you may need help to get this branch to build on RTD, just ask!)

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3fcdb14) 99.50% compared to head (48f999a) 99.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #441      +/-   ##
==========================================
- Coverage   99.50%   99.50%   -0.01%     
==========================================
  Files          12       12              
  Lines        2210     2208       -2     
==========================================
- Hits         2199     2197       -2     
  Misses         11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bhazelton bhazelton requested a review from jpober February 1, 2024 16:03
jpober
jpober previously approved these changes Feb 1, 2024
@jpober
Copy link
Member

jpober commented Feb 1, 2024

@bhazelton review is complete, but the changelog has a conflict. If you can update, I can re-approve

@bhazelton
Copy link
Member Author

@jpober done, thanks!

@jpober jpober self-requested a review February 1, 2024 18:03
jpober
jpober previously approved these changes Feb 1, 2024
@bhazelton
Copy link
Member Author

bhazelton commented Feb 1, 2024

@jpober sorry, I had to make a couple more fixes because of pytest 8 dropping. It was actually good, it pointed to some warnings filters I'd missed. I also discovered some things I'd missed in #442, so I fixed those too.

@jpober jpober self-requested a review February 1, 2024 19:21
@jpober jpober merged commit 92ab9e9 into main Feb 1, 2024
29 checks passed
@jpober jpober deleted the rm_gaussian_deprection branch February 1, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants