-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the pending deprecation warning for achromatic gaussian beams #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #441 +/- ##
==========================================
- Coverage 99.50% 99.50% -0.01%
==========================================
Files 12 12
Lines 2210 2208 -2
==========================================
- Hits 2199 2197 -2
Misses 11 11 ☔ View full report in Codecov by Sentry. |
jpober
previously approved these changes
Feb 1, 2024
@bhazelton review is complete, but the changelog has a conflict. If you can update, I can re-approve |
7ae23d0
to
0f19aa1
Compare
@jpober done, thanks! |
jpober
previously approved these changes
Feb 1, 2024
remove handling for the removed deprecation warning
0f19aa1
to
48f999a
Compare
jpober
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the deprecation warning on using sigma to define gaussian beams. Analytic beams will move to pyuvdata soon and will retain this functionality, so no deprecation is needed.
Motivation and Context
Types of changes
Checklist:
For all pull requests:
Documentation change checklist: