Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically detect dismissible site-wide drops campaigns #905

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

Rakambda
Copy link
Member

Pull Request Etiquette

Checklist

  • Tests have been added in relevant areas
  • Corresponding changes made to the documentation (README.adoc)

Type of change

New Feature

Description

Automatically detect Twitch global campaign to dismiss them as soon as they appear

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.42%. Comparing base (0f12970) to head (290bb32).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...elpointsminer/miner/runnable/UpdateStreamInfo.java 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #905      +/-   ##
=============================================
- Coverage      85.44%   85.42%   -0.03%     
- Complexity      1118     1120       +2     
=============================================
  Files            202      202              
  Lines           3511     3513       +2     
  Branches         263      263              
=============================================
+ Hits            3000     3001       +1     
  Misses           456      456              
- Partials          55       56       +1     
Flag Coverage Δ
unittests-miner 85.80% <75.00%> (-0.03%) ⬇️
unittests-viewer 58.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rakambda Rakambda merged commit aa94f79 into develop Oct 25, 2024
10 of 12 checks passed
@Rakambda Rakambda deleted the feat/auto-dismiss branch October 25, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant