Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Introduce mutation tracking query helper #178

Closed
wants to merge 1 commit into from

Conversation

smokku
Copy link

@smokku smokku commented Aug 2, 2021

This updates #92 for latest master

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@zakarumych
Copy link

User should be able to convert Mut<'a, T> into &'a mut T, which is now impossible as there's only DerefMut which returns mutable reference with lifetime limited by Mut value itself.

@Ralith
Copy link
Owner

Ralith commented Aug 12, 2021

Off the cuff, I see no reason why there couldn't be a fn into_ref(self) -> &'a mut T.

@zakarumych
Copy link

Exactly

@smokku smokku changed the title Uppdate: Introduce mutation tracking query helper Update: Introduce mutation tracking query helper Aug 12, 2021
@Ralith
Copy link
Owner

Ralith commented Feb 4, 2024

Closing in favor of #366, which is more ergonomic and should perform better in most cases.

@Ralith Ralith closed this Feb 4, 2024
@smokku
Copy link
Author

smokku commented Feb 4, 2024

It would be prudent to close this after #366 is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants