Abstract more IME specific things #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some tests, I found that commit 496e5ae does not fully align with PR #32 (74399f9). The following differs:
StartTextComposition()is called whenXNATextBox.DisableIME is false && WindowManager.IMEHandler.Enabled is falsein 74399f9. In 496e5ae,StartTextComposition()is called whenXNATextBox.IMEDisabled is false && WindowManager.IsIMEEnabled is true(note: the last true should be false). (found by @frg2089)XNATextBox.textCompositionDelay: true in 74399f9, false in 496e5aeXNATextBox.textCompositionDelay is true && string.IsNullOrEmpty(WindowManager.IMEHandler.Composition), the early return inDeleteCharacter()andBackspace()is not triggered in 74399f9, triggered in 496e5aeThe differences above stop IME from working as expected. However, instead of directly fixing them, I think it might be better to make the interface take care of these complex logics (e.g., returns whether DeleteCharacter() should have an early return for a specific XnaTextBox).
Links with CnCNet/xna-cncnet-client#537