Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert: Quick fix for expired access token problem in web component #1048

Conversation

floehopper
Copy link
Contributor

This reverts the changes in #1046.

The problem that it was addressing has now been more effectively addressed in RaspberryPiFoundation/editor-api#337.

This reverts commit eac96dd.

This commit was part of #1046. The problem that this fix was addressing
has been more effectively addressed in this editor-api PR [1].

[1]: RaspberryPiFoundation/editor-api#337.
This reverts commit 4be26c8.

This commit was part of #1046. This was in preparation for fixing a
problem that has now been more effectively addressed in this
editor-api PR [1].

[1]: RaspberryPiFoundation/editor-api#337.
Copy link

Copy link

Copy link

@chrisroos chrisroos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@floehopper floehopper merged commit 1964572 into main Jun 20, 2024
8 checks passed
@floehopper floehopper deleted the revert-quick-fix-for-expired-access-token-problem-in-web-component branch June 20, 2024 10:38
@floehopper floehopper mentioned this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants