Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor examples #94

Closed
mhchia opened this issue Aug 24, 2023 · 2 comments · Fixed by #108
Closed

Refactor examples #94

mhchia opened this issue Aug 24, 2023 · 2 comments · Fixed by #108
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mhchia
Copy link
Member

mhchia commented Aug 24, 2023

What’s wrong?

We have examples for browser and nodejs. They actually have common code snippets and should be able to be combined into one example, which makes it easier to maintain the code.

How to fix it?

We can combine two examples into one, and people can just run different commands in the same example project. For instance, npm run browser for browser and npm run node for node

@mhchia mhchia added enhancement New feature or request good first issue Good for newcomers labels Aug 24, 2023
@0xkf
Copy link
Contributor

0xkf commented Sep 15, 2023

I would like to give it a shot,

@mhchia
Copy link
Member Author

mhchia commented Sep 15, 2023

Great, thanks! Is the issue clear enough, or something you'd like to clarify? Let me know if you encounter any issues

@mhchia mhchia linked a pull request Sep 25, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants