Origin/feat/refactoring #108
Conversation
add ethers, hardhat, type module, then edited npm run command
compiled typescript to javascript. This is to make it easy to call node function.
deleted node directory, changed the name of refactored directory.
There was a problem hiding this comment.
Hey @0xkf, thanks for your excellent work! I think it can be merged with one more thing: can you remove examples/browser and examples/node? Also, can you put everything under examples/browser_node/ to examples/ and remove example/browser_node/?
Thank you for your review! |
form "npm run test" to "npm run node" or "npm run browser"
changed from "example/node_browser " directory to "example" directory
(take note that you should hit "npm run clean" after hitting "npm run browser")
|
I changed as you said. |
There was a problem hiding this comment.
Directory changes look good! It came to my mind that READMEs should also be updated. Could you do them altogether in this PR?
For examples/README.md, I've made a draft for it and you can use it directly.
For README.md, the Example section can be changed from
See [example for both NodeJS](./examples/node/) and [example for browser](./examples/browser/).to
See the [example](./examples) that can be run in both NodeJS and browser.Let me know too if you have an idea of what we should write for them
3. Run the example in a browser 4. Run the example in NodeJS ...
|
I have updated README, watching your draft. |
examples/README.md
Outdated
| @@ -20,19 +20,18 @@ In a new terminal, run: | |||
| $ npx hardhat node | |||
| ``` | |||
|
|
|||
| 3. Run the web server | |||
| 3. Run the example in a browser | |||
| (take note that you should hit "npm run clean" after hitting "npm run browser") | |||
There was a problem hiding this comment.
Is this note still relevant? If so, I'm thinking we can rephrase it to 'Try npm run clean if you've made changes to the code but the web page is not updated'
delete type module add npm run node command ""tsc --module commonjs && node dist/src/index.js""
|
I have updated as you said. |
|
Merged. Thanks for your contribution |
combined 2 directories (node and browser) to 1 directory(browser_node)
When you hit "npm run node" , it will work on node environment.
When you hit "npm run browser " , it will work on browser environment.
I edited that setting type module and compiling typescript code to javascript for node environment.
I would like to hear your feedback.
Thank you for reading