-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change to permanent urls #107
Conversation
Is it ok to use main as the branch to merge into? |
It's all good :) Thanks for the PR! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR and great work! I've asked our trusted setup team about the wasm files. Would you want to try supporting different tree depths? For example, right now we only support depth=20. With some changes we can support tree depths from 16 to 32, as the resources described in #100 (comment).
src/resources.ts
Outdated
const verificationKeyURL = `${url}/verification_key.json` | ||
const wasmFileURL = `${url}/RLN-20.wasm` | ||
const finalZkeyURL = `${url}/contributions/rln-20_final.zkey` | ||
console.log(url) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
console.log(url) |
Could you remove the console.log
s?
src/resources.ts
Outdated
const wasmFileURL = `${url}/RLN-20.wasm` | ||
const finalZkeyURL = `${url}/contributions/rln-20_final.zkey` | ||
console.log(url) | ||
console.log(wasmFileURL) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
console.log(wasmFileURL) |
src/resources.ts
Outdated
const finalZkeyURL = `${url}/contributions/rln-20_final.zkey` | ||
console.log(url) | ||
console.log(wasmFileURL) | ||
console.log(finalZkeyURL) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
console.log(finalZkeyURL) |
All the wasm files should be correct now :) I verified that they are all in wasm format |
Thank you for checking!
No, I wouldn't. |
Merged it. Thanks for your contribution |
#100
What's wrong?
Right now we're using a temporary resource, as mentioned in
rlnjs/src/resources.ts
Line 13 in 7a4a5af
How to fix
Use resources after trusted setup #100 (comment)
Problem
If you try "npm test", one test fails out of seven.
That's because the below wasm link produce a "r1cs" file.
Now, people in trusted setup team are researching the cause.
Test Error Meassage