Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated Fabric with Firebase Crashlytics #81

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

uhrohraggy
Copy link

remove deprecated Crashlytics and Fabric dependencies; replace with Firebase Crashlytics per https://firebase.google.com/docs/crashlytics/upgrade-sdk?platform=android#java

Addresses Issue #80

Comment on lines -34 to -35
import io.fabric.sdk.android.services.common.SafeToast;

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This import did not appear used, so was removed

@uhrohraggy
Copy link
Author

FYI I did leave the Fabric API key (io.fabric.ApiKey) that is hardcoded in the AndroidManifest.xml. I assumed that could be removed as well but am not sure, will leave to reviewer with more experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant