Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review edits for branch/2020-08-31/walk #34 #194

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Review edits for branch/2020-08-31/walk #34 #194

wants to merge 1 commit into from

Conversation

rptb1
Copy link
Member

@rptb1 rptb1 commented Mar 9, 2023 •
edited
Loading

We applied formal review (proc.review) to branch/2020-08-31/walk (#34 ), which had already been merged. This is a new branch for the edits arising from the review (proc.review.edit).

The review log (proc.review.doc.log) are in the pull request thread #34 and have responses there that link to commits in this branch.

@rptb1 rptb1 self-assigned this Mar 9, 2023
@rptb1
Copy link
Member Author

rptb1 commented Mar 10, 2023 •
edited
Loading

Executing proc.review.edit on #34

  1. Start time 07:00
  2. Improving the design documentation requires a fairly deep dive into the original use case, and this took a while, so not many edits yet.
  3. Edit: New API function mps_pool_walk #34 (comment) (07defbe)
  4. End time 08:15

@thejayps thejayps added the optional Will cause failures / of benefit. Worth assigning resources. label Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rptb1 rptb1

Labels
optional Will cause failures / of benefit. Worth assigning resources.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rptb1 @thejayps