-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add known DLC3 items #280
Add known DLC3 items #280
Conversation
4a0fbe5
to
fa76c69
Compare
nice work mate. |
7d2cd87
to
0615102
Compare
I've associated most of the new items with their locations but there are a couple of issues:
Instead there should be locations showing up for I'm assuming those issues are probably due to some special case handling that is no longer quite valid with the new patterns introduced by DLC3. I'll try to figure out how to fix that if someone else doesn't get to it first. Also, I would think that the new boss area |
12560d3
to
dc5d405
Compare
EDIT: I've removed the commit referenced in the comment below since it seemed to cause duplicate entries to appear sometimes. I don't think the changes I introduced should cause this but it's hard to follow the event processing logic accurately enough to determine what is causing it. In any case, I think I'll just leave the PR like this and someone more familiar with the internals can adjust as necessary.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
This PR adds support for most of the known DLC3 items (except for prisms).