Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add known DLC3 items #280

Merged
merged 1 commit into from
Sep 29, 2024
Merged

Add known DLC3 items #280

merged 1 commit into from
Sep 29, 2024

Conversation

silvanshade
Copy link
Contributor

This PR adds support for most of the known DLC3 items (except for prisms).

@Q-Sharp
Copy link
Contributor

Q-Sharp commented Sep 28, 2024

nice work mate.
@Razzmatazzz

@silvanshade
Copy link
Contributor Author

silvanshade commented Sep 28, 2024

I've associated most of the new items with their locations but there are a couple of issues:

  1. In DLC3 one shot mode, the DLC3Story area seems to be detected incorrectly. The associated location for it is detected as Losomn: Stagnant Manufactury.
  2. In DLC3 one shot mode, the POI is detected as location N'Erud: Logistics Bridge with the name The Custodian.

Instead there should be locations showing up for Agronomy Sector and Withered Necropolis.

I'm assuming those issues are probably due to some special case handling that is no longer quite valid with the new patterns introduced by DLC3. I'll try to figure out how to fix that if someone else doesn't get to it first.

Also, I would think that the new boss area The Convergence should show up and that there should be a POI or something associated with the Prototype robot. There are several items that would need to have their locations set to those to be more accurate.

@silvanshade
Copy link
Contributor Author

silvanshade commented Sep 28, 2024

EDIT: I've removed the commit referenced in the comment below since it seemed to cause duplicate entries to appear sometimes. I don't think the changes I introduced should cause this but it's hard to follow the event processing logic accurately enough to determine what is causing it. In any case, I think I'll just leave the PR like this and someone more familiar with the internals can adjust as necessary.

I've added a second commit which attempts to fix the invalid location rendering. In order to do this, I basically added another mapping from "sublocation" back to the associated "world".

This mapping is computed within the loop that loads the "subLocations" field from game.json, to try and avoid needing to add a bunch of additional data.

It seems to be sufficient to fix the problem for the few error cases I encountered but it may be that a few more locations need to be added (similar to how I have done here) if there are other cases not covered.

I considered just exhaustively adding all known locations for all of the worlds to that mapping but it seemed unnecessary. But that might be a better way to go just to be sure.

Copy link
Owner

@Razzmatazzz Razzmatazzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@Razzmatazzz Razzmatazzz merged commit 9fba878 into Razzmatazzz:main Sep 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants