Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding an atime test case; new with optimization to allow avoid [ overhead #PR4488 #6289

Closed
wants to merge 1 commit into from

Conversation

DorisAmoakohene
Copy link
Contributor

This regression was reported in #3735. They reported that selecting by row number from a data.table is much slower than from a data.frame.

The pull request that fixed the regression can be found #4488. However, I couldn’t find specific details about the changes made to fix the regression. It’s likely that the changes involved optimizing the way data.table handles row selection to make it more efficient.

@DorisAmoakohene DorisAmoakohene deleted the DorisAmoakohene-patch-2 branch July 17, 2024 00:59
Copy link

Comparison Plot

Generated via commit 30839cd

Download link for the artifact containing the test results: ↓ atime-results.zip

Time taken to finish the standard R installation steps: 12 minutes and 2 seconds

Time taken to run atime::atime_pkg on the tests: 4 minutes and 8 seconds

@tdhock
Copy link
Member

tdhock commented Jul 17, 2024

why did you open this PR and then immediately close?
Also please use more informative branch names. Current branch name is DorisAmoakohene-patch-2 which does not say anything about what you are trying to do in the PR.
something like perf-test-PR4488 would be better

@DorisAmoakohene
Copy link
Contributor Author

why did you open this PR and then immediately close? Also please use more informative branch names. Current branch name is DorisAmoakohene-patch-2 which does not say anything about what you are trying to do in the PR. something like perf-test-PR4488 would be better

I didnt close it, I renamed the branch and it closed the PR, so the new one can be found here #6290, I am still figuring out how to rename the branch name without having it duplicate the PR

@tdhock
Copy link
Member

tdhock commented Jul 17, 2024

git checkout master
git checkout -b your_branch_name

@tdhock
Copy link
Member

tdhock commented Jul 17, 2024

please use the command line git instead of the github web interface to submit PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants