setDT generates shallow copy earlier to avoid interfering with attributes of co-bound tables #6470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lass of the data.frame argument
ben-schwen
reviewed
Sep 11, 2024
ben-schwen
reviewed
Sep 11, 2024
Comment on lines
+19068
to
+19071
| d1 <- data.frame(a=1) | ||
| d2 <- d1 | ||
| setDT(d2) | ||
| test(2283, !is.data.table(d1)) |
There was a problem hiding this comment.
Suggested change
| d1 <- data.frame(a=1) | |
| d2 <- d1 | |
| setDT(d2) | |
| test(2283, !is.data.table(d1)) | |
| d1 = data.frame(a=1) | |
| d2 = d1 | |
| setDT(d2) | |
| test(2283, !is.data.table(d1)) |
data.table style guide to use = instead of <-
|
Ty for the PR. Change to looks good! To cater also for the other corner cases of d1 = data.frame(a=1:2)
rownames(d1) = c("2", "1")
d2 = d1
setDT(d2)
test(2283.2, rownames(d1), c("1", "2"))
d1 = data.frame(a=1, b=2)
colnames(d1) = c("a", "a")
d2 = d1
setDT(d2, check.names=TRUE)
test(2283.3, colnames(d1), c("a", "a")) |
MichaelChirico
changed the title
setDT in a function no longer modifies the class of a data.frame argument
|
Duplicate of #6551 (now merged) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4784.
This replaces the old PR #4901 that was never merged. The discussion/reviews there still apply.