Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding translation team logos #6519

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Adding translation team logos #6519

wants to merge 3 commits into from

Conversation

jmrung
Copy link
Contributor

@jmrung jmrung commented Sep 21, 2024

I am providing both an .svg and a high resolution .png of translation team-specific data.table logos. The differences between the main logo and translation team-specific logos are the inclusion of a two- to four-letter language code as superscripted text at the end of the package name within the logo. Full code list and additional information on codes here. I used lowercase letters since this seems most common with these codes.

I am not sure if more specific country-based versions of the language codes are needed for any of the teams (the four-letter versions of the codes, see list here). I've made one for the Brazilian team, based on recent discussions (the "pt-br" superscript), which provides a nice example of what this would look like.

Please let me know if any general changes are needed and if additional, country-specific language code versions would better serve any of the teams.

Related to #6222

This upload provides both an .svg and a high resolution .png of translation team-specific data.table logos. The differences between the main logo and translation team-specific logos are the inclusion of a two- to four-letter language code as superscripted text at the end of the package name within the logo.  [Full code list here](https://en.wikipedia.org/wiki/List_of_ISO_639_language_codes). I used lowercase letters since this seems most common with these codes.

I am not sure if more specific country-based versions of the language codes are needed for any of the teams (the four-letter versions of the codes, [see list here](https://www.andiamo.co.uk/resources/iso-language-codes/)). I've made one for the Brazilian team, based on recent discussions (file name ending with "ptbr"), which provides a nice example of what this would look like.

Please let me know if any general changes are needed and if additional, country-specific language code versions would better serve any of the teams.
@jmrung jmrung added the translation issues/PRs related to message translation projects label Sep 21, 2024
@aitap
Copy link
Contributor

aitap commented Sep 22, 2024

Do you think the logos could benefit from making the language code larger? I've tried on the avatar of the Brazilian Portuguese team by pasting the image URL into the Web developer toolbar, and the language code is just 9 pixels tall (on my relatively high-res old ThinkPad).

@MichaelChirico MichaelChirico requested review from tdhock and removed request for MichaelChirico September 23, 2024 03:09
@MichaelChirico
Copy link
Member

I think @tdhock is most familiar with the discussion here. At a glance I wonder if the code would fit better centered underneath 'data.table' rather than superscripted next to it. Maybe a slight design difference could help distinguish it, e.g. italics or a slightly different font or color. Just a thought.

@ben-schwen
Copy link
Member

Isn't there a mismatch between the .png and .svg for FR?

@@ -67,3 +67,6 @@

# docs
/man/openmp-utils.Rd @Anirban166

# meta
/.graphics/translation-team-logos/*.png @tdhock
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmrung could you please volunteer as reviewer under .graphics, since you created the new logos?

Text was not converted to path and not appropriately showing up in browser
@jmrung
Copy link
Contributor Author

jmrung commented Sep 23, 2024

Isn't there a mismatch between the .png and .svg for FR?

Good catch @ben-schwen! I missed changing the text for the language code to a path, which was causing the problem. This is fixed now in a recent commit.

@aitap & @MichaelChirico Thank you for the suggestions! I'll play around with a few possibilities to help with the readability of the language codes and post again soon to get everyone's thoughts. Moving the language code outside of the hex might be the most effective since the space inside is pretty tight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation issues/PRs related to message translation projects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants