performance test cleanup: link original benchmarks, use common N #6527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this PR also shortens the name of the CI job to "atime performance tests" (previous name was too long to read status/time on PR page) |
|
Generated via commit ab41ab9 Download link for the artifact containing the test results: ↓ atime-results.zip Time taken to finish the standard R installation steps: 3 minutes and 22 seconds Time taken to run |
| @@ -40,6 +40,7 @@ for (extra.arg in extra.args.6107){ | |||
| # @note Please check https://github.com/tdhock/atime/blob/main/vignettes/data.table.Rmd for more information. | |||
| # nolint start: undesirable_operator_linter. ':::' needed+appropriate here. | |||
| test.list <- atime::atime_test_list( | |||
| N = as.integer(10^seq(1, 7, by=0.25)), | |||
There was a problem hiding this comment.
WDYT about naming like N_grid or commonN to make it more obvious that this is a constant defined & re-used here? I sorry with just plain N that it might take a bit longer to catch on to that.
MichaelChirico
approved these changes
Sep 24, 2024
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
While reviewing/adding a performance test recently, #6526 I noticed that most other performance tests originated from issues/prs in which users reported
system.timebenchmarks, so this PR adds links to these comments.And I updated the wiki to include instructions to do this for future performance tests: "Also if there is some issue/PR comment with benchmark code that was used to derive the atime test, please include a link, as above
test case adapted from https://github.com/Rdatatable/data.table/pull/4501#issue-625311918 which is the fix PR."This PR also adds a common N which should be reasonable for any test,
N = 10^seq(1, 7, by=0.25),