Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missed/partial translations in setops/fread #6536

Merged
merged 4 commits into from
Sep 27, 2024
Merged

Conversation

MichaelChirico
Copy link
Member

@MichaelChirico MichaelChirico commented Sep 24, 2024

Towards #6532; partner: #6534

  • While we could use "condition of class %s" in fread(), I think that's less user-friendly. I suspect many (most) users will not be comfortable with that terminology, it's a relatively advanced topic in R and fread() might be the first function someone ever uses when learning R.
  • I was a bit indifferent between the approach taken here for all.equal.data.table() (change to sprintf() and gettext() a full sentence) vs. just gettext("indices"); I chose the former since sentences are typically easier to translate as a whole. (FFR: a @aitap pointed out, this is also better for translators of gendered languages, where individual words with different genders might affect translation of nearby words)

@MichaelChirico MichaelChirico added the translation issues/PRs related to message translation projects label Sep 24, 2024
Copy link

github-actions bot commented Sep 24, 2024

Comparison Plot

Generated via commit b1b9bf7

Download link for the artifact containing the test results: ↓ atime-results.zip

Time taken to finish the standard R installation steps: 3 minutes and 17 seconds

Time taken to run atime::atime_pkg on the tests: 9 minutes and 15 seconds

R/fread.R Outdated Show resolved Hide resolved
@aitap
Copy link
Contributor

aitap commented Sep 27, 2024

I'm sorry, what does it mean that I'm assigned here? I think you've fixed all the issues, at least I'm not seeing any fragmented sentences after potools::po_extract() and msgmerge. If we want to translsate the message mentioned by @rikivillalba, should I push the commit here?

@MichaelChirico
Copy link
Member Author

Since there's not really any code/logic change here, I think it's OK to get review from non-committer in this case, just hoping from a LGTM from you since you have the translator's eye for whether the changes look good. Thanks!

@MichaelChirico MichaelChirico merged commit 3734726 into master Sep 27, 2024
9 checks passed
@MichaelChirico MichaelChirico deleted the i18n-r-fragments2 branch September 27, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation issues/PRs related to message translation projects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants