Restore covr #6540
Merged
Restore covr #6540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3130f11.
|
OK, we have |
|
(side note: added @tdhock @jangorecki and @ben-schwen as admins in the codecov.io "project" for Rdatatable) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6540 +/- ##
==========================================
- Coverage 97.51% 97.02% -0.49%
==========================================
Files 80 81 +1
Lines 14979 14708 -271
==========================================
- Hits 14607 14271 -336
- Misses 372 437 +65 ☔ View full report in Codecov by Sentry. |
|
Looks like we've lost 0.44% coverage since the last upload 6f3fc8d :) |
|
not bad thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6479.
First tried reverting the old GHA, but I think there was a cacheing issue there as we continued to segfault even with old R. Therefore I cribbed the code-coverage GHA from dplyr which is structurally a bit different. With that change our codecov passes again, once I pinned the R version to
<4.4.I also generated+added a CODECOV_TOKEN under our repo secrets.