Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Improve Settings order #2060

Merged
merged 20 commits into from
Aug 15, 2024
Merged

feat: Improve Settings order #2060

merged 20 commits into from
Aug 15, 2024

Conversation

validcube
Copy link
Member

Improve Settings

image

@validcube validcube added the ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager label Jul 14, 2024
@validcube validcube linked an issue Jul 14, 2024 that may be closed by this pull request
feat: Improve setting descriptions #1965
Closed
3 tasks
@validcube validcube changed the title feat: Settings v2 feat: Improve Settings order Jul 14, 2024
@validcube validcube marked this pull request as draft July 14, 2024 10:43
@Axelen123
Copy link
Member

I think the "general" screen should be renamed. It only contains appearance settings

@oSumAtrIX
Copy link
Member

How about "Visual" or "Design"?

@validcube validcube marked this pull request as ready for review August 5, 2024 14:41
@validcube validcube requested a review from Axelen123 August 7, 2024 15:31
@oSumAtrIX
Copy link
Member

Please update the attached image in OP as well

@validcube
Copy link
Member Author

validcube commented Aug 9, 2024 •
edited
Loading

This PR also additionally allow making a listview without description for self-explanatory label or developer option.

@validcube validcube requested a review from Axelen123 August 9, 2024 04:45
@validcube validcube requested a review from Axelen123 August 10, 2024 16:18
Axelen123
Axelen123 requested changes Aug 11, 2024
View reviewed changes
app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
@validcube validcube requested a review from Axelen123 August 11, 2024 16:20
@Axelen123 Axelen123 merged commit 747017a into compose-dev Aug 15, 2024
2 checks passed
@Axelen123 Axelen123 deleted the settings-reorder branch August 15, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Axelen123 Axelen123 Axelen123 approved these changes

@oSumAtrIX oSumAtrIX Awaiting requested review from oSumAtrIX

Assignees
No one assigned
Labels
ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Improve setting descriptions
3 participants
@validcube @Axelen123 @oSumAtrIX