Skip to content
This repository has been archived by the owner on Apr 20, 2018. It is now read-only.

Uses rx.all.js as the main file #472

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

faloi
Copy link

@faloi faloi commented Dec 30, 2014

Hi, I'm suggesting this change because it makes a lot more sense to me than the current approach. Right now each script is added at least twice (full and minified version) and that's a problem when you have an automatic tool to add bower scripts to your index.html.

I'd like to hear your opinion on this! 😄

@mattpodwysocki
Copy link
Member

@faloi is it common to use all of Rx or just the pieces you need? Rx.all is rather large...

@faloi
Copy link
Author

faloi commented Feb 9, 2015

So far, I've only used Rx in one project and I think that the lite version should be ok. However, the problem remains: I still need to manually delete the files I don't want to include.

@brettstack
Copy link

I agree. I'm not sure which file(s) should be in the main property, but it should definitely be changed from what it currently is.

Ideally each library would be published in a separate repo (bower-rxjs-async, bower-rxjs-aggregate, etc.) so that the main repo can just include the core rxjs file in the main property, and any additional libraries you need would need to be added through bower. This is the way many projects (Angular for example) do it.

@@ -2,57 +2,7 @@
"name": "rxjs",
"version": "2.3.22",
"main": [

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With only one file, this doesn't need to be an array.

"main": "dist/rx.all.js",

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants