Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Solve memory leak in Promise::fromObservable #198

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

WyriHaximus
Copy link
Contributor

Work in progress, don't merge yet. Going to commit in stages

@bartvanhoutte
Copy link
Contributor

Seems like I'm running into the same issue. @WyriHaximus Is this a problem that has to get fixed or is this eventually caught by GC?

@WyriHaximus
Copy link
Contributor Author

@bartvanhoutte I utterly forgot about this, well you have two kinds of memory leaks in PHP, the ones that the GC will clean up and the ones that the GC doesn't clean up. The ones the GC will clean up are ignorable until a certain point. The otherones aren't. So the question is, is the GC cleaning up what you are seeing? I'll get on this PR again soon and get it ready for review and merging 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants