Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support template types #218

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support template types #218

wants to merge 1 commit into from

Conversation

WyriHaximus
Copy link
Contributor

@WyriHaximus WyriHaximus commented Aug 7, 2023 •
edited
Loading

Depends on #217

@WyriHaximus WyriHaximus mentioned this pull request Aug 7, 2023
Merged
@WyriHaximus WyriHaximus force-pushed the template-types branch 11 times, most recently from 022ee96 to 006cb2a Compare November 27, 2023 22:51
@WyriHaximus WyriHaximus mentioned this pull request Nov 30, 2023
Open
WyriHaximus added a commit to WyriHaximus/reactphp-awaitable-observable that referenced this pull request Nov 30, 2023
@WyriHaximus
Add template types
4508757 
Requires: ReactiveX/RxPHP#218
@WyriHaximus WyriHaximus force-pushed the template-types branch 3 times, most recently from 9c0ae45 to 63ee9a6 Compare December 2, 2023 18:40
@WyriHaximus WyriHaximus marked this pull request as ready for review December 2, 2023 18:44
WyriHaximus
WyriHaximus commented Dec 2, 2023
View reviewed changes
phpstan.neon.dist
@@ -2,7 +2,8 @@ parameters:
level: max

paths:
- src/
- test/types/
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't widen this to include the entire test directory because that would add 1752 errors to solve. This PR alone was already almost 1K.

WyriHaximus
WyriHaximus commented Dec 2, 2023
View reviewed changes
src/Operator/ThrottleOperator.php
* @var Observable<T> $observable
*/
$observable = Observable::of($x, $this->scheduler);
$newDisp = $observable->delay($this->nextSend - $now, $this->scheduler)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is interesting, while this class accepts the SchedulerInterface which can also be the AsyncSchedulerInterface however. The delay method on an observable only accepts the AsyncSchedulerInterface. What to do here?

@WyriHaximus WyriHaximus changed the title [WIP] Add support template types [Add support template types Dec 2, 2023
@WyriHaximus
Copy link
Contributor Author

@davidwdan && @mbonneau This covers the basics ( 😅 ) and is ready for review. Is there anything you want me to add in the test/types/ set of type tests? Will do some package type testing tomorrow in WyriHaximus/reactphp-awaitable-observable#65

WyriHaximus added a commit to WyriHaximus/reactphp-awaitable-observable that referenced this pull request Dec 3, 2023
@WyriHaximus
Add template types
6579062 
Requires: ReactiveX/RxPHP#218
WyriHaximus added a commit to WyriHaximus/reactphp-awaitable-observable that referenced this pull request Dec 3, 2023
@WyriHaximus
Add template types
d32b617 
Requires: ReactiveX/RxPHP#218
@WyriHaximus
Copy link
Contributor Author

The first package update was successful based on this branch:
Package PR: WyriHaximus/reactphp-awaitable-observable#65
Failing Job: https://github.com/WyriHaximus/reactphp-awaitable-observable/actions/runs/7075959624/job/19258667203
Successful Job: https://github.com/WyriHaximus/reactphp-awaitable-observable/actions/runs/7075997261/job/19258748448

@WyriHaximus WyriHaximus changed the title [Add support template types Add support template types Dec 6, 2023
WyriHaximus added a commit to WyriHaximus/reactphp-awaitable-observable that referenced this pull request Dec 13, 2023
@WyriHaximus
Add template types
fce34bc 
Requires: ReactiveX/RxPHP#218
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@WyriHaximus