Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(serviceConfig): restructure for readability #1520

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Feb 14, 2025

What's included

  • test(serviceConfig): restructure for readability

Notes

  • the polling config checks throw an intermittent/random-like test flake typically seen when running nodejs 20. this attempts to restructure the test and provide mock resets for the "mock axios" calls per test instead of "after all"
    • similar tests around settimeout in other repos, with github actions and multiple nodejs versions being checked, almost always present with a lesser nodejs version failing around settimeout

How to test

Example

...

Updates issue/story

ongoing

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.40%. Comparing base (7d32bdd) to head (489d81f).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1520   +/-   ##
=======================================
  Coverage   91.40%   91.40%           
=======================================
  Files         115      115           
  Lines        4723     4723           
  Branches     2190     2190           
=======================================
  Hits         4317     4317           
  Misses        380      380           
  Partials       26       26           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d32bdd...489d81f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants