Use tags from API instead of mocked ones #278
Conversation
Codecov Report
@@ Coverage Diff @@
## master #278 +/- ##
==========================================
+ Coverage 59.29% 59.34% +0.04%
==========================================
Files 166 166
Lines 2501 2499 -2
Branches 457 457
==========================================
Hits 1483 1483
+ Misses 848 846 -2
Partials 170 170
Continue to review full report at Codecov.
|
karelhala
force-pushed
the
use-api-tags
branch
from
1e5240c
to
dbfb286
Compare
karelhala
changed the title
karelhala
added
release
packages/inventory/src/api/index.js
Outdated
| ...data, | ||
| results: data.results.map(row => ({ ...row, tags: tags[row.id] || [] })) | ||
| })) | ||
| .catch(() => ({ |
There was a problem hiding this comment.
This is safe way how not to fail on fetching tags (they are something trivial and shouldn't break the UI)
karelhala
force-pushed
the
use-api-tags
branch
from
dbfb286
to
4ea588f
Compare
There was a problem hiding this comment.
Everything looks good; in terms of functionality/code. I did notice when I was npm linking that this depends on repository.engineering.redhat.com. I thought we were using regular npm registry because we wanted community contributions or is that something only for insights-chrome?
|
@yashnalla mhhh, that is trange. I can't seem to be able to find any reference to it in lock file https://raw.githubusercontent.com/RedHatInsights/frontend-components/d14a0e3b12899a3922cd5737445d3d46c7069d4c/package-lock.json |
|
:soon::shipit::octocat: |
|
🌱 🌸 🌷 🌻 🌟 New version of package has been released 🌟 🌻 🌷 🌸 🌱 The release is available on: :package:@redhat-cloud-services/frontend-components-inventory-general-info/v/0.0.14📦 :boom:This feature is brought to you by probot🚀 |
|
🌱 🌸 🌷 🌻 🌟 New version of package has been released 🌟 🌻 🌷 🌸 🌱 The release is available on: :package:@redhat-cloud-services/frontend-components-inventory/v/0.0.36📦 :boom:This feature is brought to you by probot🚀 |
|
Yea i noticed that too; I didn't see it when I was npm installing; just npm linking. No idea why. Might just be some npm behavior I don't know about. |
TODO:
/hostsendpoint insights-host-inventory#517UI changes