Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten api names to prevent confusion #226

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Shorten api names to prevent confusion #226

merged 1 commit into from
Mar 21, 2024

Conversation

apinkert
Copy link
Contributor

@apinkert apinkert requested a review from a team March 19, 2024 16:31
Copy link
Contributor

@Hyperkid123 Hyperkid123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apinkert the generator has to change not the index files. If you generate the client, it will override these changes.

This is the template for the root index file: https://github.com/RedHatInsights/javascript-clients/blob/ce375d507d94dab9f57facb8e2f99848900476bd/src/main/resources/typescript-axios-webpack-module-federation/index.mustache

@apinkert
Copy link
Contributor Author

@apinkert the generator has to change not the index files. If you generate the client, it will override these changes.

This is the template for the root index file: https://github.com/RedHatInsights/javascript-clients/blob/ce375d507d94dab9f57facb8e2f99848900476bd/src/main/resources/typescript-axios-webpack-module-federation/index.mustache

Updated the template and regenerated the index.ts files for both with npm run generate:prod

@Hyperkid123 Hyperkid123 merged commit b7d834a into main Mar 21, 2024
6 checks passed
@apinkert apinkert deleted the rename-exports branch April 3, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants