[HMS-5265]: Replace edge widget with a new image-builder #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aferd
reviewed
Jan 7, 2025
| @@ -1,17 +1,17 @@ | |||
| import React from 'react'; | |||
| import { SimpleServiceWidget } from './simple-service-widget'; | |||
|
|
|||
| const EdgeWidget: React.FunctionComponent = () => { | |||
| const ImagesWidget: React.FunctionComponent = () => { | |||
There was a problem hiding this comment.
since you added a new widget in a separate file, I don't think we need to keep this one any longer.
you will also need to add the new widget to the dashboard.cy.ts cypress E2E test.
There was a problem hiding this comment.
Thanks @aferd 👍
I removed Edge
Also I updated the dashboard template
RedHatInsights/chrome-service-backend#749
Hyperkid123
requested changes
Jan 13, 2025
fec.config.js
Outdated
| @@ -45,9 +45,9 @@ module.exports = { | |||
| __dirname, | |||
| 'src/components/widgets/explore-capabilities.tsx' | |||
| ), | |||
| './EdgeWidget': path.resolve( | |||
There was a problem hiding this comment.
If we remove the widget, it will break existing dashboards as they will still reference the old one. We need both widgets until a migration is done to customized dashboard.
There was a problem hiding this comment.
Makes sense, let's keep these two widget and update just the default dashboard layout.
Hyperkid123
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the outdated Edge service widget with a new widget showcasing the "Image Builder" service. The updated widget should provide a clear, concise description of Image Builder's capabilities and include a link for the service.
Screenshots
Before:
After:
Checklist ☑️