Update advisor.yml #260
Update advisor.yml #260
Conversation
Adding cards on the top from Advisor for Pathways, Incidents, Critical recommendations, Important recommendations.
github-actions
bot
added
advisor
|
@mmenestr does this make sense pls? |
data/advisor.yml
Outdated
| @@ -3,6 +3,18 @@ advisor: | |||
| color: 2 | |||
| features: | |||
| _scope: '[data-ouia-app-id="advisor"]' | |||
| "Advisor - Card: Pathways": | |||
| selectors: | |||
| - '{}[data-testid="Pathways"]' | |||
There was a problem hiding this comment.
I think you need a space between the {} and the rest of the selector. Otherwise looks good.
Same for all of them
There was a problem hiding this comment.
but the rest of the existing ones do not have that space. Or am I misunderstanding the position of the space
There was a problem hiding this comment.
They should all have the space
https://github.com/RedHatInsights/pendo-config-automation/blob/main/docs/data.md#selectors
i made some spaces, but not sure if those are the ones mentioned in the comment
I added the spaces, hopefully i got it from reading the document and comments
|
Hey, sorry -- On my review, I was just talking about the ones that you added, not the rest of the file. Everything that was there already is spaced correctly. It's just due to how the selectors appear in the DOM, the ones you added need that extra space. |
i hope this is the one
|
we are getting there @ryelo hopefully this is the last edit 🔪 |
Adding cards on the top from Advisor for