Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webapp): add go controller for packages endpoint #1233

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

Dugowitch
Copy link
Contributor

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

Copy link

jira-linking bot commented Jan 20, 2025

Commits missing Jira IDs:
8868298
Referenced Jiras:
https://issues.redhat.com/browse/RHINENG-13557

@Dugowitch Dugowitch force-pushed the packages-controller branch 2 times, most recently from 85d5578 to a03be26 Compare January 21, 2025 10:19
@Dugowitch Dugowitch force-pushed the packages-controller branch 2 times, most recently from afcc760 to 1535379 Compare February 12, 2025 10:24
@Dugowitch Dugowitch requested a review from psegedy February 12, 2025 10:25
@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 34 lines in your changes missing coverage. Please review.

Project coverage is 61.14%. Comparing base (5a56460) to head (8868298).
Report is 216 commits behind head on master.

Files with missing lines Patch % Lines
vmaas-go/webapp/controllers/packages.go 0.00% 29 Missing ⚠️
vmaas-go/webapp/routes/routes.go 0.00% 4 Missing ⚠️
vmaas-go/base/utils/config.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1233      +/-   ##
==========================================
- Coverage   62.98%   61.14%   -1.84%     
==========================================
  Files          70       94      +24     
  Lines        6800     6957     +157     
==========================================
- Hits         4283     4254      -29     
- Misses       2517     2694     +177     
- Partials        0        9       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dugowitch Dugowitch marked this pull request as ready for review February 13, 2025 18:14
@psegedy
Copy link
Member

psegedy commented Feb 14, 2025

/retest

Since Go 1.22, loop vars don't need to be copied and exportloopref is
deprecated.
@psegedy
Copy link
Member

psegedy commented Feb 18, 2025

@mtclinton @Dugowitch Only 2 tests are failing, I modified those tests in iqe-vmaas. Merging

@psegedy psegedy merged commit ebda868 into RedHatInsights:master Feb 18, 2025
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants