Fixes #YUPTOO-37 - omit nics starts with & associated mac_addrs

[kgaikwad]

No description provided.

[patilsuraj767]

Hello @kgaikwad Thanks for creating the PR, Modifiers are designed to be independent of each other. One modifier should not import the other. Will request you to shift whole code under single modifier.

[kgaikwad]

Hello @kgaikwad Thanks for creating the PR, Modifiers are designed to be independent of each other. One modifier should not import the other. Will request you to shift whole code under single modifier.

As I am modifying mac_addresses field details of host, I won't prefer to move mac_addresses specific code into file named as transform_network_interfaces.py. In addition to this, logic extracted into a static method so it can be easily imported from anywhere.
My intention was to keep all transformations related to mac_addresses inside one file i.e transform_mac_addresses.py so that in future one can add changes just by looking into single file and anticipate the impact of change.
I can move this method to different utils file, will it work for you? thoughts?

[patilsuraj767]

Yes, we can move the logic in different utils file which is outside modifier directory. Once issue 30 is fixed we can move the code to new modifier file.

[kgaikwad]

Moved helper method to different file. Please request to review.

[kgaikwad]

Once issue 30 is fixed we can move the code to new modifier file.

Btw, I didn't get how this is relevant to issue 30. As per understanding these are two different things.

[r14chandra]

lgtm! 👍🏻

[patilsuraj767]

Once issue 30 is fixed we can move the code to new modifier file.

Btw, I didn't get how this is relevant to issue 30. As per understanding these are two different things.

@kgaikwad what I meant was once we have issue 30 fixed and once we have dependency graph mechanism in place. Then we can create a separate modifier for omitting nics and add its dependency in transform_network_interfaces.py. That way all the code can be in one file + transform_network_interfaces modifier will run after omitting nics modifier.

[patilsuraj767]

Thanks for the PR @kgaikwad, Approving and merging it.