Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Podman Containers client support #490

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Podman Containers client support #490

merged 1 commit into from
Sep 30, 2024

Conversation

jyejare
Copy link
Contributor

@jyejare jyejare commented Sep 3, 2024 •
edited
Loading

PR adds:

  • The new podman system in the support for container type resource
  • New podman requirement is added
  • The podman system belongs to container systems package
  • The class PodmanContainer represents the podman container and has properties and functions around it.

Blocks:

@jyejare jyejare marked this pull request as draft September 3, 2024 08:32
@jyejare jyejare mentioned this pull request Sep 18, 2024
Merged
@jyejare jyejare self-assigned this Sep 18, 2024
@jyejare jyejare marked this pull request as ready for review September 18, 2024 11:29
JacobCallahan
JacobCallahan requested changes Sep 18, 2024
View reviewed changes
wrapanapi/systems/container/podman.py Show resolved Hide resolved
wrapanapi/systems/container/podman.py Outdated Show resolved Hide resolved
wrapanapi/systems/container/podman.py Outdated Show resolved Hide resolved
wrapanapi/systems/container/podman.py Outdated Show resolved Hide resolved
@jyejare jyejare force-pushed the podman_client branch 3 times, most recently from 81e0d9d to 9933fba Compare September 23, 2024 13:56
@JacobCallahan JacobCallahan merged commit 12e61d0 into master Sep 30, 2024
3 checks passed
@JacobCallahan JacobCallahan deleted the podman_client branch September 30, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobCallahan JacobCallahan JacobCallahan approved these changes

@omkarkhatavkar28 omkarkhatavkar28 omkarkhatavkar28 approved these changes

Assignees

@jyejare jyejare

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jyejare @JacobCallahan @omkarkhatavkar28