fix ConcurrentModificationException when other text watchers are installed #140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I experienced this in a react-native app when using another library, LogRocket, which globally scans for text views to install their own text watcher for analytics purposes.
And along with react-native, I have these installed as well:
What triggers the crash is:
afterTextChanged
is called which modifies the list while it's being iteratedConcurrentModificationException
during the check for comodification.If not for (3), the crash is avoided.
With this PR, I was able to substitute this library out for a patched one and confirmed it fixes the issue.
Let me know if you need anything else.