Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes flake.nix #403

Merged
merged 5 commits into from
Sep 4, 2023
Merged

Fixes flake.nix #403

merged 5 commits into from
Sep 4, 2023

Conversation

solomon-b
Copy link
Contributor

@solomon-b solomon-b commented Aug 30, 2023

Rewrites flake.nix and pins some libraries to get the nix shell environment and nix builds working.

Note that I had to pin Kado prior to 17206ca3d01fada34e34e60e1995b03609292b61 which has a breaking change.

@solomon-b
Copy link
Contributor Author

@favonia I hope you don't mind I rewrote the flake to match the polytt one.

@favonia
Copy link
Collaborator

favonia commented Sep 3, 2023

@solomon-b Thank you! I believe cooltt does need the latest version of kado. (Concretely, Cof.cof was changed to Cof.t.)

In any case, we might also need you to to transfer copyright to "RedPRL Development Team" as in #346. We can do it after this PR, though.

@favonia favonia linked an issue Sep 3, 2023 that may be closed by this pull request
@solomon-b
Copy link
Contributor Author

@solomon-b Thank you! I believe cooltt does need the latest version of kado. (Concretely, Cof.cof was changed to Cof.t.)

Oh I must have been on an old cooltt commit. I've updated the pin and all is working.

In any case, we might also need you to to transfer copyright to "RedPRL Development Team" as in #346. We can do it after this PR, though.

No problem!

.gitignore Outdated Show resolved Hide resolved
@favonia favonia merged commit ce1ba90 into RedPRL:main Sep 4, 2023
1 check passed
@favonia
Copy link
Collaborator

favonia commented Sep 4, 2023

@solomon-b Yeah! Thank you!

@favonia
Copy link
Collaborator

favonia commented Sep 21, 2023

@solomon-b I have two questions: (1) What name do you want us to put into CONTRIBUTORS.md for you? (I plan to start a PR to add your name.) (2) Do you have a ready-to-use GitHub Actions template that tests the Nix files?

@solomon-b
Copy link
Contributor Author

@solomon-b I have two questions: (1) What name do you want us to put into CONTRIBUTORS.md for you? (I plan to start a PR to add your name.) (2) Do you have a ready-to-use GitHub Actions template that tests the Nix files?

You can put me under Solomon Bothwell.

I don't have an ocaml specific nix github CI action but I can try to throw something together.

@favonia
Copy link
Collaborator

favonia commented Sep 21, 2023

@solomon-b Thanks. Just to clarify that the GitHub Actions is not urgent (and I thought your project could benefit from it too).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nix Flake: No matching version for bwd >= 2.1
2 participants