[WIP] Stream reader #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented stream decoding Not happy with: (WIP - for now) - Windows: having to use `Skia` - Android: seems slow but it's no the stream conversion
Extended the example project to use stream decoding on two new pages
|
Hey @Redth, don't suppose you've had time to look at this? |
|
Hey @Redth, me again, nudge, nudge... wink, wink 😁 |
- Improved speed slightly on android - Dropped requirement for `Microsoft.Maui.Graphics.Skia` - Let `RGBLuminanceSource` do the hard work of discovering the `BitmapFormat`
|
If anyone can test this on IOS and mac then I can remove the draft 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added stream reading functionality - hope you can help @Redth 😁
WIP Reasons:
Windows: not happy with using(seeSkia- is there an alternative? Couldn't really find anything myselfImprovementspush)Sidenote - android is very slow decoding (thought it was my code, but it wasn't) - see images. Windows completes the whole process in a little over a second.Edit:
Improvementspush has sped things up a little (letting Zxing choose format)Old screengrabs