Drop players armor and weapons

[RedRafe]

Changes

• fixed typo in configs offline_timout_mins --> offline_timeout_mins
• added config to drop player's armor and weapons alongside player's inventory when logging off

This issue was raised on Admins chat to retrieve player's armor/weapons when players are banned, and also when players disconnect hoarding a lot of stuff. So the new config has a field startup_gear_drop_hours = 24 which means:

• ANY player logging off in the first 24h will drop their armor alongside inventory/weapons
• Rank::Regular and above will NOT drop their armor after first 24h of game (but they will still drop inventory (+weapons) as usual.

if not banned and player.connected then return end

I removed this check because it was not clear to me what edge case it was supposed to gate. The new conditions appeared to be always true so it seemed redundant, but happy to revert it.
Also I added a debug option to drop player's stuff in debug mode, but could be too much overhead so it can be removed if we prefer... I've tested it in all the cases (except ban) and it's unlikely I'll need to retest this often

screenshot of the changes

[grilledham]

I think this is mostly fine and a welcome improvement. As this is functionally used by multiple maps I want to play test it before I approve. And I want to wait for your thoughts on my comments before I play test.

[grilledham]

I think this check was to cover the case were the player re-connects after the timer has been started. Which we don't care about if they were banned as we don't go through the timer in that case.

If you agree this is needed, I think we should add this check back.

[RedRafe]

cover the case were the player re-connects after the timer has been started

Ah that might be it, thanks! Reverting

[grilledham]

I think the debug code would make more sense in start_timer. I assume it's really the set_timeout_in_ticks you are trying to avoid for testing purposes. And if it's for testing it makes sense to run as much of the real code as possible.

Maybe something like this in start_timer would be better:

local data = {player = player, tick = tick, timeout_minutes = timeout_minutes}
if _DEBUG then
    local spawn_player_corpse_func = Token.get(spawn_player_corpse_token)
    spawn_player_corpse_func(data)
else
   set_timeout_in_ticks(timeout, spawn_player_corpse_token, data)
end

[RedRafe]

OKay I've decided I dont care about debug mode, and If we'll have to debug, just reduce the waiting time in configs or wait/speed up game if needed. So removed all the debug junk

[RedRafe]

So the biggest issue for me was testing this feature, because I had to start a SP game, save it, load it to our server, startup it and then join/leave. And it's tricky because in SP when you exit the game it gets paused, while in MP it register your leave. So my SP leave would actually trigger the 1st boot of the game on server side, and then trigger regularly when joining/leaving server as usual. The issue is that when the server boots up and the leave triggers, player.connect would be false, while when joining/leaving a running server, since it runs on PRE-player leave, that check sees player.connect = true.

This is just a big mess to correctly debug, and that's why I left the debug code in it (which I usually dont), BUT I dont like to leave it on, because it makes the actual working logic so much more complex to maintain/read IMO. Maybe I'd prefer to leave it in code as commented (so could be temporarily de-commented if we need to refactor/debug in the future cuz it would be helpful to have it there and not figuring out this big loophole again), or maybe figure a better workflow that would work all round. I also dont want it to run on _DEBUG = true cuz we unlikely will want to drop our invs when testing other stuff around the maps.

Maybe was just easier to leave the timeout thing as is and just speed up to 100x from console after leaving to simulate it (or reduce time to <1m), but yeah... didnt think of it before

[RedRafe]

Yes I forgot to mention in the refactor I wanted scenarios to be able to set timeout = 0 to let invs drop instantly when leaving and prev version would not allow it (I guess a workaround would be to set it to 1/60 or whatever <1 min so it just happens next tick or very shortly still which is good enough)

[RedRafe]

@grilledham reverted the check for online players; and removed the debug stuff: I dont think that is necessary to keep it and would just make debugging other scenarios tedious.

[grilledham]

Made some changes to set a default values just in case. I've tested and looks good. Thanks for doing this.