Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve perf for dynamic index / fieldname (Restore the generated function perf) #35

Merged
merged 7 commits into from
Jan 24, 2025

Conversation

NHDaly
Copy link
Member

@NHDaly NHDaly commented Jan 22, 2025

Fix a regression introduced in #28.

We need to do the field => index lookup at compiletime, but we cannot guarantee we'll get a compiler-constant fieldname.

So we precompute the entire lookup table (as a NamedTuple), then do the lookup in there. If the name is a compiler-constant, great, the lookup compiles away. But even if not, the lookup is very cheap.

Before:

julia> @btime getindex($foo, $2)
  209.277 ns (2 allocations: 48 bytes)
Blob{Float32}(Ptr{Nothing} @0x000000014b1feed0, 8, 12)

julia> @btime getproperty($foo, $(:x))
  1.833 μs (5 allocations: 176 bytes)
Blob{Int64}(Ptr{Nothing} @0x000000014b1feed0, 0, 12)

julia> @btime getproperty($foo, $(:y))
  1.275 μs (4 allocations: 128 bytes)
Blob{Float32}(Ptr{Nothing} @0x000000014b1feed0, 8, 12)

After:

julia> @btime getindex($foo, $2)
  85.196 ns (2 allocations: 48 bytes)
Blob{Float32}(Ptr{Nothing} @0x000000014b1feed0, 8, 12)

julia> @btime getproperty($foo, $(:x))
  99.912 ns (2 allocations: 48 bytes)
Blob{Int64}(Ptr{Nothing} @0x000000014b1feed0, 0, 12)

julia> @btime getproperty($foo, $(:y))
  107.028 ns (2 allocations: 48 bytes)
Blob{Float32}(Ptr{Nothing} @0x000000014b1feed0, 8, 12)

Probably the much more likely/relevant case would be a field-access on a type-unstable blobs value. For example x.y where x does not have a known type. This was very expensive before this PR:

julia> @btime ((a)->a[1].y)($(Any[foo]))
  1.458 μs (8 allocations: 352 bytes)
Blob{Float32}(Ptr{Nothing} @0x000000016fe73d90, 8, 12)

and now it's reasonable again:

julia> @btime ((a)->a[1].y)($(Any[foo]))
  115.105 ns (2 allocations: 48 bytes)
Blob{Float32}(Ptr{Nothing} @0x000000016fe73d90, 8, 12)

@NHDaly NHDaly requested a review from Sacha0 January 22, 2025 20:28
@Sacha0
Copy link
Contributor

Sacha0 commented Jan 24, 2025

❤️ ❤️ ❤️

Copy link
Contributor

@Sacha0 Sacha0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nathan! I love the elegant recursions. My curiosities should not hold this patch up :).

@NHDaly NHDaly merged commit 6668537 into main Jan 24, 2025
4 checks passed
@NHDaly NHDaly deleted the nhd-getindex-perf-dynamic branch January 24, 2025 21:43
NHDaly added a commit that referenced this pull request Jan 24, 2025
…tch perf (#36)

There's a known issue with dynamic dispatch (Thanks to @topolarity to pointing this out) where it's super slow if you dispatch on a type / constructor.

Our code had a dispatch on Blob{FT} with an unknown FT in the case of a dynamic field access. That was causing very slow performance.

By changing this to a helper function (make_blob), we do a performant dispatch, dramatically improving perf.

Now, dynamic field access on a Blob has the ~same~ even better performance as dynamic field access on a regular julia object! :)

Before:
```julia
julia> @Btime ((a)->a[1].y)($(Any[foo]))
  115.105 ns (2 allocations: 48 bytes)
Blob{Float32}(Ptr{Nothing} @0x000000016fe73d90, 8, 12)
```

After:
```julia
julia> @Btime ((a)->a[1].y)($(Any[foo]))
  48.015 ns (1 allocation: 32 bytes)
Blob{Float32}(Ptr{Nothing} @0x000000016fe73d90, 8, 12)

# Comparison to getproperty on a normal struct:
julia> @Btime ((a)->a[1].y)($(Any[Foo(2,3)]))
  52.550 ns (2 allocations: 48 bytes)
3.0f0
```

Follow up to #35.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants