-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve perf for dynamic index / fieldname (Restore the generated function perf) #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❤️ ❤️ ❤️ |
Sacha0
reviewed
Jan 24, 2025
Sacha0
reviewed
Jan 24, 2025
Sacha0
reviewed
Jan 24, 2025
Sacha0
reviewed
Jan 24, 2025
Sacha0
reviewed
Jan 24, 2025
Sacha0
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Nathan! I love the elegant recursions. My curiosities should not hold this patch up :).
NHDaly
added a commit
that referenced
this pull request
Jan 24, 2025
…tch perf (#36) There's a known issue with dynamic dispatch (Thanks to @topolarity to pointing this out) where it's super slow if you dispatch on a type / constructor. Our code had a dispatch on Blob{FT} with an unknown FT in the case of a dynamic field access. That was causing very slow performance. By changing this to a helper function (make_blob), we do a performant dispatch, dramatically improving perf. Now, dynamic field access on a Blob has the ~same~ even better performance as dynamic field access on a regular julia object! :) Before: ```julia julia> @Btime ((a)->a[1].y)($(Any[foo])) 115.105 ns (2 allocations: 48 bytes) Blob{Float32}(Ptr{Nothing} @0x000000016fe73d90, 8, 12) ``` After: ```julia julia> @Btime ((a)->a[1].y)($(Any[foo])) 48.015 ns (1 allocation: 32 bytes) Blob{Float32}(Ptr{Nothing} @0x000000016fe73d90, 8, 12) # Comparison to getproperty on a normal struct: julia> @Btime ((a)->a[1].y)($(Any[Foo(2,3)])) 52.550 ns (2 allocations: 48 bytes) 3.0f0 ``` Follow up to #35.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a regression introduced in #28.
We need to do the field => index lookup at compiletime, but we cannot guarantee we'll get a compiler-constant fieldname.
So we precompute the entire lookup table (as a NamedTuple), then do the lookup in there. If the name is a compiler-constant, great, the lookup compiles away. But even if not, the lookup is very cheap.
Before:
After:
Probably the much more likely/relevant case would be a field-access on a type-unstable blobs value. For example
x.y
wherex
does not have a known type. This was very expensive before this PR:and now it's reasonable again: