Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix/makeEditingReviewSpecific #108

Merged
merged 8 commits into from
Jan 10, 2025
Merged

Conversation

trialnerr
Copy link
Collaborator

#105:

  1. Fix editing bug by rendering CompanyReviews in Profile
  2. Validate the number added during edit to be cast to 1 if its less than 0 and 5 if its greater than 5
  3. Remove console logs
  4. Add margin to list items to space them out.

…if numbers outside of range are added they are readjusted. Delete console logs
…inside of Profile to prevent editing state being shared by all children.
@branic18
Copy link
Collaborator

@trialnerr Everything works, except the Salary incrementor within the Profile Edit Review. For example, if I try to change Salary from 5 to 3 and save it, the change is still 5.

Copy link
Collaborator Author

@trialnerr trialnerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok on it!

Copy link
Collaborator

@branic18 branic18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The salary incrementor works!

@branic18 branic18 merged commit 768616a into main Jan 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants