CampaignDataLoader: Make CheckScriptVersion private

It is only required for the load method if that succeeds the script version was fine.
Return-To-The-Roots · Jun 6, 2024 · 6102ff9 · 6102ff9
1 parent 13a991c
commit 6102ff9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/libs/libGamedata/lua/CampaignDataLoader.h b/libs/libGamedata/lua/CampaignDataLoader.h
@@ -18,8 +18,6 @@ class CampaignDataLoader : public LuaInterfaceBase
     CampaignDataLoader(CampaignDescription& campaignDesc, const boost::filesystem::path& basePath);
     ~CampaignDataLoader() override;
 
-    bool CheckScriptVersion();
-
     /// Return version of the interface. Changes here reflect breaking changes
     static unsigned GetVersion();
 
@@ -30,4 +28,6 @@ class CampaignDataLoader : public LuaInterfaceBase
 private:
     CampaignDescription& campaignDesc_;
     boost::filesystem::path basePath_;
+
+    bool CheckScriptVersion();
 };
diff --git a/tests/s25Main/campaign/testCampaignLuaFile.cpp b/tests/s25Main/campaign/testCampaignLuaFile.cpp
@@ -64,7 +64,6 @@ BOOST_AUTO_TEST_CASE(ScriptVersion)
         CampaignDataLoader loader(desc, tmp);
         rttr::test::LogAccessor logAcc;
         BOOST_TEST_REQUIRE(loader.Load());
-        BOOST_TEST(loader.CheckScriptVersion());
         logAcc.clearLog();
     }
 
@@ -79,7 +78,6 @@ BOOST_AUTO_TEST_CASE(ScriptVersion)
         CampaignDataLoader loader(desc, tmp);
         rttr::test::LogAccessor logAcc;
         BOOST_TEST_REQUIRE(loader.Load());
-        BOOST_TEST(loader.CheckScriptVersion());
         logAcc.clearLog();
         BOOST_TEST_PASSPOINT();
     }