Fix replay test #1676
Merged
Fix replay test #1676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The replay tests (running a large replay checking for loading and asyncs) is only done for optimized builds because they are already slow. This exists currently only on Appveyor which is Windows only and not as visible as GHA. So add an optimized build to GHA.
Flamefire
force-pushed
the
fix-replay-test
branch
2 times, most recently
from
3db8f6f
to
f3cc0e7
Compare
Includes the Mini-UPnP compat fix and `Tell` improvement Adapt types in `Replay` to fix signed/unsigned mismatch adapt comments and write compressed flag after starting compression
Flamefire
force-pushed
the
fix-replay-test
branch
from
f3cc0e7
to
092d52b
Compare
We don't use Travis for ages anymore
Fix skipping the autoplay test
After the fix for the fishers in 6898d93 the replays need to be regenerated
Merged
The image was updated and 1.77 removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #1675 the replay gets async which is currently only caught by the appveyor CI
The replay tests (running a large replay checking for loading and asyncs) is only done for optimized builds because they are already slow.
This exists currently only on Appveyor which is Windows only and not as visible as GHA.
So add an optimized build to GHA.
Once this commit fails I'll add updated replays.