Refactoring of existing cheats (see #1679) #1688
Conversation
There was a problem hiding this comment.
Great use of the circular buffer, good idea!
It does make sense to separate the cheats and the key/command tracker although I don't really like putting the cheats into the world class or having the command tracker be a part of the cheats creating a cyclic dependency and having to do cheats.trackX -> tracker.trackX
So maybe add an instance of each class to the game interface?
kubaau
force-pushed
the
cheats_refactoring
branch
2 times, most recently
from
0aa5e63 to
f6baefc
Compare
…ass "CheatCommandTracker"
- avoid early returns - rename cheatStr to enableCheatsStr - rename canCheatModeBeOn() to areCheatsAllowed() - trackCharKeyEvent return void - hold cheatCmdTracker_ by value instead of unique_ptr
kubaau
force-pushed
the
cheats_refactoring
branch
3 times, most recently
from
97793f3 to
0665d3d
Compare
kubaau
force-pushed
the
cheats_refactoring
branch
from
0665d3d to
5934fd7
Compare
kubaau
force-pushed
the
cheats_refactoring
branch
from
5934fd7 to
92e9c95
Compare
Moved CheatCommandTracker out of Cheats and into dskGameInterface as it is its only user. |
|
@Flamefire Please review the updates. Sorry for the huge delay :D |
kubaau
force-pushed
the
cheats_refactoring
branch
2 times, most recently
from
02cfb70 to
543fd96
Compare
kubaau
force-pushed
the
cheats_refactoring
branch
from
543fd96 to
e761d04
Compare
There was a problem hiding this comment.
Looks good to me, thanks! But see the comment for the future.
First few commits from PR #1679 :