Add Required v1 API Features With Tests & CI
#2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Local database management turned out to not be such a good idea. Why? because now users can apply existing analysis in rizin and cutter plugins and hence no need to track binary id or analysis id or hashes of uploaded files. If this new feature were not to be added, then local db management is a very helpful feature to have IMO
- Auth Check endpoint works - Log object management removed, Log now available globally. Logging will be initialized as soon as the library is loaded and all logs will be stored in tmpdir.
API key works correctly only with it's corresponding host. Auth check now sets the host as well.
Add new endpoint to get available AI models
Plugins now don't use a static modelname-version syntax to specify versions. All AI model information is passed into the struct of arguments of API that requires it.
There are some bugs found during execution of these tests Strange, I never thought they'd exist like this. While writing the tests I thought they'd be useless.
The bug still remains unfixed.
The json string getter method does not duplicate the string and hence ownership still remained with cJSON object. One of the Json getter method destroyed the returned string and hence it was a double-free bug, because in the end the cJSON object tried to destroy it was well. Phew!
Recently faced a RPATH issue when building and installing cJSON from source on Mac OS. The updated README provides hints on how that can be fixed.
Documentation for `/v1/ann/symbol/batch` seems to be incorrect. Can't wait for getting a response and then making decision based on that, so for now moving ahead with a hack to optionally check for `function_matches` field the second time. I'm referring to the JSON response parsing code in Response.c
Some small non-necessary fixes to follow a proper coding style throughout.
No need to explicitly sets variables to `NULL` after using `FREE` on them, this is automatically done in `FREE` macro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will be a huge set of changes for the
creaitlibrary. Until this PR is merged, all plugins are usingv1branch of this library on checkout in their correspondingDockerfileMerging of this PR will also result in
v1of creait library and then I can make progress towards adding some new features fromv2of the API