Write unit tests for FinancialVisualization Settings (KpiTimeVisualizationSettingsFixture)

src/Reveal.Sdk.Dom.Tests/Visualizations/Settings/KpiTimeVisualizationSettingsFixture.cs

@@ -0,0 +1,120 @@
+using Newtonsoft.Json.Linq;
+using Reveal.Sdk.Dom.Core.Constants;
+using Reveal.Sdk.Dom.Visualizations;
+using Reveal.Sdk.Dom.Visualizations.Settings;
+using Reveal.Sdk.Dom.Visualizations.VisualizationSpecs;
+using Xunit;
+
+namespace Reveal.Sdk.Dom.Tests.Visualizations.Settings;
+
+public class KpiTimeVisualizationSettingsFixture
+{
+    [Fact]
+    public void Constructor_FieldsHaveDefaultValues_WhenInstanceIsCreated()
+    {
+        // Act
+        var settings = new KpiTimeVisualizationSettings();
+
+        // Assert
+        Assert.Equal(SchemaTypeNames.IndicatorVisualizationSettingsType, settings.SchemaTypeName);
+        Assert.Equal(VisualizationTypes.INDICATOR, settings.VisualizationType);
+        Assert.Null(settings.VisualizationDataSpec);
+    }
+
+    [Theory]
+    [InlineData(null, IndicatorVisualizationType.MonthToDatePreviousMonth)]
+    [InlineData(KpiTimePeriod.MonthToDatePreviousMonth, IndicatorVisualizationType.MonthToDatePreviousMonth)]
+    [InlineData(KpiTimePeriod.MonthToDatePreviousYear, IndicatorVisualizationType.MonthToDatePreviousYear)]
+    [InlineData(KpiTimePeriod.QuarterToDatePreviousQuarter, IndicatorVisualizationType.QuarterToDatePreviousQuarter)]
+    [InlineData(KpiTimePeriod.QuarterToDatePreviousYear, IndicatorVisualizationType.QuarterToDatePreviousYear)]
+    [InlineData(KpiTimePeriod.YearToDatePreviousYear, IndicatorVisualizationType.YearToDatePreviousYear)]
+    internal void TimePeriod_SetAndGet_UpdatesVisualizationDataSpec(
+        KpiTimePeriod timePeriod,
+        IndicatorVisualizationType expectedIndicatorType)
+    {
+        // Arrange
+        var settings = new KpiTimeVisualizationSettings
+        {
+            VisualizationDataSpec = new IndicatorVisualizationDataSpec()
+        };
+
+        // Act
+        settings.TimePeriod = timePeriod;
+
+        // Assert
+        Assert.Equal(timePeriod, settings.TimePeriod);
+        Assert.Equal(expectedIndicatorType, settings.VisualizationDataSpec.IndicatorType);
+    }
+
+    [Fact]
+    public void ToJsonString_GeneratesCorrectJson_WhenSerialized()
+    {
+        // Arrange
+        var expectedJson =
+            """
+            {
+              "_type" : "IndicatorVisualizationSettingsType",
+              "DifferenceMode" : "ValueAndPercentage",
+              "PositiveIsRed" : false,
+              "IncludeToday" : true,
+              "VisualizationType" : "INDICATOR"
+            }
+            """;
+
+        var settings = new KpiTimeVisualizationSettings
+        {
+            VisualizationDataSpec = new IndicatorVisualizationDataSpec(),
+            DifferenceMode = IndicatorDifferenceMode.ValueAndPercentage,
+            PositiveIsRed = false,
+            IncludeToday = true,
+            TimePeriod = KpiTimePeriod.QuarterToDatePreviousYear
+        };
+
+        // Act
+        var actualJson = settings.ToJsonString();
+        var expectedJObject = JObject.Parse(expectedJson);
+        var actualJObject = JObject.Parse(actualJson);
+
+        // Assert
+        Assert.Equal(expectedJObject, actualJObject);
+    }
+
+    [Theory]
+    [InlineData(KpiTimePeriod.MonthToDatePreviousMonth, IndicatorVisualizationType.MonthToDatePreviousMonth)]
+    [InlineData(KpiTimePeriod.MonthToDatePreviousYear, IndicatorVisualizationType.MonthToDatePreviousYear)]
+    [InlineData(KpiTimePeriod.QuarterToDatePreviousQuarter, IndicatorVisualizationType.QuarterToDatePreviousQuarter)]
+    [InlineData(KpiTimePeriod.QuarterToDatePreviousYear, IndicatorVisualizationType.QuarterToDatePreviousYear)]
+    [InlineData(KpiTimePeriod.YearToDatePreviousYear, IndicatorVisualizationType.YearToDatePreviousYear)]
+    [InlineData((KpiTimePeriod)999, IndicatorVisualizationType.MonthToDatePreviousMonth)]
+    internal void ConvertKpiTimePeriodToIndicatorVisualizationType_MapCorrectly_WhenCalled(KpiTimePeriod input, IndicatorVisualizationType expected)
+    {
+        // Arrange
+        var settings = new KpiTimeVisualizationSettings();
+
+        // Act
+        var result = settings.ConvertKpiTimePeriodToIndicatorVisualizationType(input);
+
+        // Assert
+        Assert.Equal(expected, result);
+    }
+
+    [Theory]
+    [InlineData(IndicatorVisualizationType.MonthToDatePreviousMonth, KpiTimePeriod.MonthToDatePreviousMonth)]
+    [InlineData(IndicatorVisualizationType.MonthToDatePreviousYear, KpiTimePeriod.MonthToDatePreviousYear)]
+    [InlineData(IndicatorVisualizationType.QuarterToDatePreviousQuarter, KpiTimePeriod.QuarterToDatePreviousQuarter)]
+    [InlineData(IndicatorVisualizationType.QuarterToDatePreviousYear, KpiTimePeriod.QuarterToDatePreviousYear)]
+    [InlineData(IndicatorVisualizationType.YearToDatePreviousYear, KpiTimePeriod.YearToDatePreviousYear)]
+    [InlineData((IndicatorVisualizationType)999, KpiTimePeriod.MonthToDatePreviousMonth)]
+    internal void ConvertIndicatorVisualizationTypeToKpiTimePeriod_MapCorrectly_WhenCalled(IndicatorVisualizationType input, KpiTimePeriod expected)
+    {
+        // Arrange
+        var settings = new KpiTimeVisualizationSettings();
+
+        // Act
+        var result = settings.ConvertIndicatorVisualizationTypeToKpiTimePeriod(input);
+
+        // Assert
+        Assert.Equal(expected, result);
+    }
+
+}

src/Reveal.Sdk.Dom/Visualizations/Settings/KpiTimeVisualizationSettings.cs

@@ -24,7 +24,7 @@ public KpiTimePeriod TimePeriod
 
         internal IndicatorVisualizationDataSpec VisualizationDataSpec { get; set; }
 
-        IndicatorVisualizationType ConvertKpiTimePeriodToIndicatorVisualizationType(KpiTimePeriod timePeriod)
+        internal IndicatorVisualizationType ConvertKpiTimePeriodToIndicatorVisualizationType(KpiTimePeriod timePeriod)
         {
             return timePeriod switch
             {
@@ -37,7 +37,7 @@ IndicatorVisualizationType ConvertKpiTimePeriodToIndicatorVisualizationType(KpiT
             };
         }
 
-        KpiTimePeriod ConvertIndicatorVisualizationTypeToKpiTimePeriod(IndicatorVisualizationType visualizationType)
+        internal KpiTimePeriod ConvertIndicatorVisualizationTypeToKpiTimePeriod(IndicatorVisualizationType visualizationType)
         {
             return visualizationType switch
             {