Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optimal value markers to tolerance sliders #5973

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

dligr
Copy link
Member

@dligr dligr commented Mar 2, 2025

Brief Description of What This PR Does

Adds markers which indicate optimal tolerance values of the patch. Also adds min/max value labels at the ends of sliders.

This is supposed to improve the clarity of the tolerance panel and make it easier to find good tolerance values.

image

Related Issues

--

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • PR author has checked that this PR works as intended and doesn't
    break existing features:
    https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
    (this is important as to not waste the time of Thrive team
    members reviewing this PR)
  • Initial code review passed (this and further items should not be checked by the PR author)
  • Functionality is confirmed working by another person (see above checklist link)
  • Final code review is passed and code conforms to the
    styleguide.

Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.

@dligr dligr added the review label Mar 2, 2025
@dligr dligr added this to the Release 0.8.2 milestone Mar 2, 2025
@dligr dligr requested review from a team March 2, 2025 14:37
@hhyyrylainen
Copy link
Member

I'll wait checking this until I'm done with the feature of organelles affecting the tolerances as that needs quite a lot of GUI changes (which sadly will then mean there will be merge conflicts here).

@hhyyrylainen
Copy link
Member

This can now continue with this being merged: #5969

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

2 participants