Changed position usage to localPosition for text & letter effects

RhenaudTheLukark · Jan 29, 2024 · 38626aa · 38626aa
1 parent 0cf2e8c
commit 38626aa
Show file tree

Hide file tree

Showing 8 changed files with 10 additions and 10 deletions.
diff --git a/Assets/Scripts/Text/TextEffect/RotatingEffect.cs b/Assets/Scripts/Text/TextEffect/RotatingEffect.cs
@@ -18,7 +18,7 @@ protected override void UpdateInternal() {
             RectTransform rt = textMan.letters[i].image.GetComponent<RectTransform>();
             Vector2 oldPosition = positions[i];
             positions[i] = new Vector2(intensity * -Mathf.Sin(iDiv), intensity * Mathf.Cos(iDiv));
-            rt.position += (Vector3)(positions[i] - oldPosition);
+            rt.localPosition += (Vector3)(positions[i] - oldPosition);
         }
 
         sinTimer += Time.deltaTime;

diff --git a/Assets/Scripts/Text/TextEffect/ShakeEffect.cs b/Assets/Scripts/Text/TextEffect/ShakeEffect.cs
@@ -20,7 +20,7 @@ protected override void UpdateInternal() {
             float random = Random.value * 2.0f * Mathf.PI;
             Vector2 oldPosition = positions[i];
             positions[i] = new Vector2(Mathf.Sin(random) * intensity, Mathf.Cos(random) * intensity);
-            rt.position += (Vector3)(positions[i] - oldPosition);
+            rt.localPosition += (Vector3)(positions[i] - oldPosition);
         }
     }
 }
diff --git a/Assets/Scripts/Text/TextEffect/TextEffect.cs b/Assets/Scripts/Text/TextEffect/TextEffect.cs
@@ -22,6 +22,6 @@ public void UpdateEffects() {
     ~TextEffect() {
         for (int i = 0; i < positions.Count; i++)
             if (textMan != null && textMan.letters[i].image != null)
-                textMan.letters[i].image.transform.position -= (Vector3)positions[i];
+                textMan.letters[i].image.transform.localPosition -= (Vector3)positions[i];
     }
 }
diff --git a/Assets/Scripts/Text/TextEffect/TwitchEffect.cs b/Assets/Scripts/Text/TextEffect/TwitchEffect.cs
@@ -25,7 +25,7 @@ protected override void UpdateInternal() {
 
         // Move back last character
         if (updateCount == 0 && selectedChar >= 0 && selectedChar < textMan.letters.Count && rt) {
-            rt.position -= (Vector3)positions[selectedChar];
+            rt.localPosition -= (Vector3)positions[selectedChar];
             positions[selectedChar] = new Vector2();
         }
 
@@ -39,7 +39,7 @@ protected override void UpdateInternal() {
         selectedChar = Random.Range(0, textMan.letters.Count);
         positions[selectedChar] = new Vector2(Mathf.Sin(random) * intensity, Mathf.Cos(random) * intensity);
         rt = textMan.letters[selectedChar].image.GetComponent<RectTransform>();
-        rt.position += (Vector3)positions[selectedChar];
+        rt.localPosition += (Vector3)positions[selectedChar];
     }
 
     private int GetNextWigTime() { return avgWigFrames + Mathf.RoundToInt(wigFrameVariety * (Random.value * 2 - 1)); }

diff --git a/Assets/Scripts/Text/TextEffectLetter/RotatingEffectLetter.cs b/Assets/Scripts/Text/TextEffectLetter/RotatingEffectLetter.cs
@@ -19,6 +19,6 @@ protected override void UpdateInternal() {
         float oldYPos = yPos;
         xPos = intensity * -Mathf.Sin(iDiv);
         yPos = intensity * Mathf.Cos(iDiv);
-        rt.position += new Vector3(xPos - oldXPos, yPos - oldYPos, 0);
+        rt.localPosition += new Vector3(xPos - oldXPos, yPos - oldYPos, 0);
     }
 }
diff --git a/Assets/Scripts/Text/TextEffectLetter/ShakeEffectLetter.cs b/Assets/Scripts/Text/TextEffectLetter/ShakeEffectLetter.cs
@@ -20,6 +20,6 @@ protected override void UpdateInternal() {
         float oldYPos = yPos;
         xPos = Mathf.Sin(random) * intensity;
         yPos = Mathf.Cos(random) * intensity;
-        rt.position += new Vector3(xPos - oldXPos, yPos - oldYPos, 0);
+        rt.localPosition += new Vector3(xPos - oldXPos, yPos - oldYPos, 0);
     }
 }
diff --git a/Assets/Scripts/Text/TextEffectLetter/TextEffectLetter.cs b/Assets/Scripts/Text/TextEffectLetter/TextEffectLetter.cs
@@ -15,6 +15,6 @@ protected TextEffectLetter(Letter letter) {
 
     ~TextEffectLetter() {
         if (letter)
-            rt.position -= new Vector3(xPos, yPos, 0);
+            rt.localPosition -= new Vector3(xPos, yPos, 0);
     }
 }
diff --git a/Assets/Scripts/Text/TextEffectLetter/TwitchEffectLetter.cs b/Assets/Scripts/Text/TextEffectLetter/TwitchEffectLetter.cs
@@ -19,7 +19,7 @@ public TwitchEffectLetter(Letter letter, float intensity = 2.0f, int step = 0) :
 
     protected override void UpdateInternal() {
         if (updateCount == 0) {
-            rt.position -= new Vector3(xPos, yPos);
+            rt.localPosition -= new Vector3(xPos, yPos);
             xPos = yPos = 0;
         }
 
@@ -32,7 +32,7 @@ protected override void UpdateInternal() {
         float random = Random.value * 2.0f * Mathf.PI;
         xPos = Mathf.Sin(random) * intensity;
         yPos = Mathf.Cos(random) * intensity;
-        rt.position += new Vector3(xPos, yPos);
+        rt.localPosition += new Vector3(xPos, yPos);
     }
 
     private int GetNextWigTime() { return avgWigFrames + Mathf.RoundToInt(wigFrameVariety * (Random.value * 2 - 1)); }