Changed autoprobe behavior to average instead of exact match #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version probes every site 5 times and reports the average of the 5 as the measurement rather than waiting for an exact match across 21 probings. It is possible that probing may take a small bit longer, but for many who's probe are not repeatable enough to match in fewer than 5 probings this may be the only way to complete the process and get useable (not perfect) results.
The mode/median filter first tests for an exact match, as the original autocalibration method did. If it finds an exact match to the first probe, it will run as normal, i.e. cut short the probing and move to the next spot. If it does not find an exact match to the first probe, it will construct an array of the probe points (set to do 7 probes) and test for the mode value. If it finds a mode it will report that, if no mode is found or if a bimodal situation is found, it will report the median instead. There are some diagnostic reports to tell what the individual probe points are, as well as if it's an exact match or mode/median and what is the range of the probes for each site.
Added the ability to change autocalibration probe offsets like M666 P Xnn Ynn Znn. The original M666 Pnn still works to change only the Z offset. Added ability to change the probing speed of G30 (not yet G29) like G30 A Fnnn (requires a new config variable PROBING_FEEDRATE) Fixed layout of autocalibration report for Repetier Host (Host seems to barf on printing a string containing "B"
PROBING_FEEDRATE will be used by G30 autocalibration, and can be changed on the fly by G30 A Fnnn
|
Hey Rich, what are your thoughts about the median mode filter making it into your upstream? Looks like github automagically added all of my updates to this pull request, but since you're about to roll a new version, should I make a pull request adding the median mode and perhaps the Repeteir reporting fix after you've merged your development to master? |
tidy up markdown for github preview
This was a bug found back in the summer in Rich's Marlin, but which apparently was never fixed. This worked much better in my local copy so I finally got back to making the change here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version probes every site 5 times and reports the average of the 5 as the measurement rather than waiting for an exact match across 21 probings. It is possible that probing may take a small bit longer, but for many who's probe are not repeatable enough to match in fewer than 5 probings this may be the only way to complete the process and get useable (not perfect) results.
You will notice that each of the 5 probes and their average are reported as they are being probed. Apart from that everything else will look the same.